Skip to content

Update Accessibility & Localization #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 19, 2024

Conversation

pinkeshmars
Copy link
Collaborator

Description

Update Accessibility & Localization

Linear ticket and magic word Fixes DEVR-376

Type of change

  • Typo fix
  • New feature
  • Enhancement to current docs
  • Removed outdated references
  • Update assets

@pinkeshmars pinkeshmars requested a review from PoojaB26 November 11, 2024 11:47
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

- **Keyboard Navigation for Physical Impairments**: Users unable to use touchscreens can navigate the app effectively with keyboard controls.
- **Haptic Feedback**: Tactile responses help users with visual or motor impairments understand when interactions are successful.

## Adding Accessibility
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this heading necessary?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can go to the next paragraph right away as this section doesnt have much, only just creates the segue to the next section.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya can do that!


There are two ways you can manage the app text translation:

### Inside Language Settings
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be bullet points itself? Or just bold headings will work. No need for headers.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, made it bold.

In FlutterFlow, you can retrieve the following types of language-related data:

- **Current Language Code**: This provides the ISO language code for the current app language (e.g., en, de, fr).
- **Language-Dependent Text**: Allows you to specify different values for each language. For instance, you might want to display a country flag or name based on the current app language.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I havent used this much, so dont know much about this language dependent text. Who is specifying these values for each language? the user? From the image it seems to me that I can use this value on text properties but then I dont get "Allows you to specify different values for each language"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is set by the user. Think of it like conditional values based on language. It is helpful in cases where you don't want to show translated text instead, show something else like a flag or anything.


![retrieve-lang-data.png](imgs/retrieve-lang-data.png)

## Formatting Dates, Numbers, and Currency
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Formatting Dates, Numbers, and Currency
## Localizing Dates, Numbers, and Currency

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also as SEO & search point of view, I would rather not have this header and just have 3 main headers - Localizing Dates, Localizing Numbers etc because they are unrelated to each other right? So no point in keeping them under this header which anyway has no purpose as such other than just a single intro. So maybe we get rid of this header and promote the other headers?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! removed it.

- **Change Device Locale**: Test your app by changing the device locale to verify translations and layout adjustments.
- **Use Emulators**: Use Android or iOS emulators to simulate different locales and ensure everything is displaying correctly.
- **Long Texts**: Verify that long translations do not overflow or cause UI issues.
- **Manual Testing**: Manually verify the accuracy of translations, date formats, number formats, etc.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think somewhere in the doc (either here or as an example) we should mention about handling RTL languages

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked into it, but we don't support RTL languages natively in FF.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh interesting!

@pinkeshmars
Copy link
Collaborator Author

@PoojaB26 review comments are resolved. You can take a look again.

Copy link
Collaborator

@PoojaB26 PoojaB26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@PoojaB26 PoojaB26 merged commit d9e4264 into main Nov 19, 2024
1 check passed
@PoojaB26 PoojaB26 deleted the pinkesh/accessibility-internationalisation branch November 19, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants